Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : add design token #26

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat : add design token #26

wants to merge 3 commits into from

Conversation

Jun99uu
Copy link
Member

@Jun99uu Jun99uu commented Feb 13, 2023 •
edited
Loading

Issue

Resolves #25 25

Description

디자인토큰 (색상토큰 + 텍스트토큰)입니다.

Check List

  • PR 제목을 커밋 규칙에 맞게 작성
  • 적절한 라벨 설정
  • GitHub Projects에 연결
  • 작업한 사람 모두를 Assign
  • Code Review 요청
  • 올라온 PR 중 DB Schema를 바꾸는 PR이 없는지 확인
  • DB Schema를 바꾼 경우, 다른 PR이 없는지 확인
  • main 브랜치의 최신 상태를 반영하고 있는지 확인

@Jun99uu Jun99uu added the feature 기능 추가/수정 label Feb 13, 2023
@vercel
Copy link

vercel bot commented Feb 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2023 8:34am

@Jun99uu Jun99uu temporarily deployed to Preview February 13, 2023 08:16 — with GitHub Actions Inactive
kanghyun98
kanghyun98 requested changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@kanghyun98 kanghyun98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍎 파일 위치가 잘못된 것 같습니다!
상수(토큰)은 /src/constants/ 경로에 저장되어야 하고, 스타일 관련 값들은 해당 경로 하위에 style 폴더를 만들어서 색상과 상수를 구분하면 좋을 것 같습니다!

다른 사항들은 제가 디자인 팀이 아니라 잘 모르기도 해서...
다른분들 의견을 들으셔야 할 것 같아요ㅎㅎ

ballsona
ballsona previously approved these changes Mar 7, 2023
View reviewed changes
Copy link

@ballsona ballsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업하시느라 수고하셨습니다 준규님!!
강현님 말씀대루 src/constants/styles/ 내에 두 파일이 들어가면 좋을 것 같아요!

@Jun99uu Jun99uu temporarily deployed to Preview April 12, 2023 08:31 — with GitHub Actions Inactive
@Jun99uu Jun99uu temporarily deployed to Preview April 12, 2023 08:31 — with GitHub Actions Inactive
@Jun99uu Jun99uu marked this pull request as ready for review April 12, 2023 08:32
@Jun99uu Jun99uu requested a review from kanghyun98 April 12, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ballsona ballsona ballsona left review comments

@kanghyun98 kanghyun98 Awaiting requested review from kanghyun98

Assignees

@aube-dev aube-dev

@Jun99uu Jun99uu

@yoo-jimin127 yoo-jimin127

@ballsona ballsona

Labels
feature 기능 추가/수정
Projects
gdsc-ssu-web
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Common Design Token
5 participants
@Jun99uu @ballsona @kanghyun98 @aube-dev @yoo-jimin127